User talk:Ahasuerus

From ISFDB
Jump to navigation Jump to search

See User talk:Ahasuerus/Archive for discussions prior to 2023.

PLEASE NOTE:

If you're writing to inform me that you've either added a COVER IMAGE or NOTES to any of my VERIFIED PUBS, please follow THIS LINK and add it to the bottom of the list. A link to the pub record would be appreciated. Once the pub has been reviewed, I'll remove your note from the list. Thanks!

Cornish

Hi, and Happy New Year! Sorry to add to your plate, but it looks like we need Cornish for Myghal Palmer and Rebellyans. In the obituary, his brother-in-law says this was published in Cornish and that at the time (2005) Palmer was responsible for 4 of the 6 (sic) books published in revived Cornish.... --MartyD (talk) 14:02, 3 January 2023 (EST)

No worries! Cornish is an ISO 639-2-recognized language, so it doesn't cause any issues. I added it a couple of minutes ago. Happy New Year! Ahasuerus (talk) 14:23, 3 January 2023 (EST)
Such speedy service! TYVM! --MartyD (talk) 20:51, 4 January 2023 (EST)

AddPub Approval page issue

When the title of the new publication does not match the title of the record you are adding into, there is no warning anymore. See here. It cannot happen outside of an API call (as the field is greyed out) but that makes processing Fixer's AddPub submissions extremely finicky (and is potentially going to lead to more missed mismatches if anyone else uses the API to submit these and the handling moderator relies on the screens to tell them of a mismatch). Annie (talk) 14:28, 27 January 2023 (EST)

PS: I think that the problem is that you never show the Publication title now on the screen - so there is no place for the warning to be shown. Annie (talk) 14:30, 27 January 2023 (EST)
I see. Thanks for reporting the problem. Let me finish testing the patch that I put together this morning and then I'll work on fixing the bug. Ahasuerus (talk) 15:04, 27 January 2023 (EST)
OK, I think I have it fixed on the development server, but it's 6:30pm on the East Coast and I don't trust my brain to test things thoroughly at this hour. I'll do the testing tomorrow morning. Ahasuerus (talk) 18:38, 27 January 2023 (EST)
No worries - I know to watch out for it and I do not think we have anyone active now that uses the API so we should be fine for a few days. Annie (talk) 19:11, 27 January 2023 (EST)
OK, I think I fixed everything. Please let me know if anything looks wrong. Thanks. Ahasuerus (talk) 13:31, 28 January 2023 (EST)
Looks good. Will take a second to get used to it being down there but it makes more sense with how the submission page is structured anyway :) Annie (talk) 17:59, 30 January 2023 (EST)
I figured that having a complete Title record in the Title table and a complete Publication record in the Publication table made more sense. The reviewer no longer needs to guess which Title field values are re-used by the Publication table.
I also realized that, for manually created AddPubs, it's possible for the pub's title/authors to get out of sync with the associated title's title/authors. All it takes is for an Edit Title submission to be approved before the AddPub submission is processed. Ahasuerus (talk) 18:07, 30 January 2023 (EST)

Mismatched Quotes Weirdness

There is a mismatched quotes warning for the synopsis field in this submitted edit. The warning appears in the proposed value column with the warning cell completely missing. I realize that this is because the missing closing quote makes the browser think that the anchor tag is not finished. I don't know if we want to consider escaping values here, or if this is a rare enough occurrence that we shouldn't worry about a cosmetic issue. In any case, I'll leave it un-approved so you can take a look. Thanks. --Ron ~ RtraceTalk 11:05, 16 February 2023 (EST)

I see. I think this issue is limited to Notes and Synopsis fields because they are the only ones where we allow embedded HTML (although I see that Help:Using Templates and HTML in Note Fields doesn't mention Synopsis.) I suppose the ideal solution would be to tell the browser that it should stop parsing HTML at the end of the current table cell, but I am afraid I don't know of a way to do it. Ahasuerus (talk) 12:04, 16 February 2023 (EST)

Yellow warning request

I think we need one more yellow warning on the approval screen: when AddPub had been already submitted and someone changes the type of the original we are adding to, you don't get any indication of it. Example here. I swapped the type from novel to chapbook pre-approval so I can make it in one step so I knew to check but if the approver does not open the resulting new publication, there is nothing to tell them that the work just approved needs work (And with the type missing from the top, they cannot even spot it on the screen). Annie (talk) 11:48, 23 February 2023 (EST)

PS: I think we may end up in the same situation with a ClonePub as well - I just don't have one handy as an example. Thanks! Annie (talk) 11:56, 23 February 2023 (EST)
Excellent points. FR 1561, "Enhance AddPub/ClonePub post-submission pages". Ahasuerus (talk) 17:54, 23 February 2023 (EST)
All done. Ahasuerus (talk) 23:41, 7 March 2023 (EST)
Awesome! Can you look at this one. See the top of the screen that says The Scourge Between Stars • (2023). Historically, and everywhere on the server, the year is shown that way anywhere ONLY if the title date is different from the one of the publication you are working on - so different from 2023-04-04. So seeing a year in bracket, always sent me doing sanity check on dates to see if one may need adjusting. But they match here. Is that intentional? Annie (talk) 11:20, 9 March 2023 (EST)
It looks like it was an oversight in SVN patch 1108, which implemented FR 1227, "Display the full title line for Add/ClonePub submissions", on 2023-03-05. I am busy today, but I hope to get it fixed tomorrow. Thanks for identifying the issue! Ahasuerus (talk) 14:30, 9 March 2023 (EST)
No rush and if it ends up being too complicated, I can get used to it behaving this way going forward. It looked like a quick way to see that the ebook date is not the same as the paper we are adding it to when I do the ebooks for Forthcoming books - that made me recheck the date on the paper one as well a few times today. I can just start comparing the dates on my own instead and ignore the year up there - both dates are on the screen now after all. :) Annie (talk) 18:23, 9 March 2023 (EST)
It should be fixed now. Ahasuerus (talk) 17:03, 11 March 2023 (EST)

Author birthplace question

The editor originally entered the birthplace for M. L. Weems as 'Anne Arundel County, Province of Maryland, Thirteen Colonies, British America'; triggering an exception for noncompliance with this template. I tried substituting 'England, Kingdom of Great Britain' for 'Thirteen Colonies, British America', but the software still see it as an exception. Is 'Province of Maryland' causing the software to look for USA? What is the correct fix? I'm stumped. John Scifibones 16:55, 25 February 2023 (EST)

Checking the code, I see that it expects the names of US states to be followed by ", USA" with a few exceptions: California allows "Baja California", Hawaii allows "Kingdom of Hawaii" and "Republic of Hawaii", Montana allows "Bulgaria", etc. Some of the original 13 colonies allow ", British Empire", but Maryland is not one of them. I'll need to update the code to support ", British Empire" for Maryland and the rest of the colonies. Thanks for identifying the problem! Ahasuerus (talk) 17:12, 25 February 2023 (EST)
Bug 828 has been created. We'll probably need to update the Help template as well. Ahasuerus (talk) 17:14, 25 February 2023 (EST)
Should I go ahead and update the author in anticipation of the change? John Scifibones 17:42, 25 February 2023 (EST)
Please do. It may take me a couple of days to get to it since there is a lot going on right now. Ahasuerus (talk) 17:45, 25 February 2023 (EST)
I have installed a patch to address the issue. All 13 colonies should be handled properly now. The counts will be updated when the cleanup reports run at 1am EST. Sorry about the delay. Ahasuerus (talk) 19:40, 3 March 2023 (EST)

Self-Approver

Hello, can you please comment on https://isfdb.org/wiki/index.php/ISFDB:Community_Portal#Self-Moderation_Request? --Stoecker (talk) 06:44, 11 March 2023 (EST)

Done. Ahasuerus (talk) 10:03, 11 March 2023 (EST)

Offutt EILSB

https://www.isfdb.org/cgi-bin/view_submission.cgi?5606444; Do you think the day of publication or the ISBN should be entered? --Username (talk) 08:49, 13 March 2023 (EDT)

Help:Screen:NewPub#Date says that:
  • The base date optionally may be made more precise (e.g., supplying the month or day of publication) using information from a secondary source, if that source's date is otherwise consistent with publication's stated date. The source, and which details of the date were obtained from that source, must be recorded in the publication notes.
so we could make the date more precise and state the source in Notes.
Re: ISBN, Help:Screen:NewPub#ISBN allows padding a 9-digit SBN with a zero to make it a valid 10-digit ISBN, but creating a 10-digit ISBN based on a much shorter catalog ID ("64-490") seems like a stretch. We could always raise the question on the Rules and Standards page. For now I have approved the submission. Ahasuerus (talk) 13:49, 13 March 2023 (EDT)

Problem with an approved edit

When you have a few minutes, would you mind taking a look at the thread Neal Stephenson / Snow Crash? Thanks John Scifibones 19:31, 18 March 2023 (EDT)

That's odd. I will restore the full backups (which include submission history) on the development server tomorrow morning and see what I can find. Thanks for reporting the issue. Ahasuerus (talk) 23:55, 18 March 2023 (EDT)